Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code for feature-gates HighAvailability, SelfHosting, CertsInSecrets #1072

Closed
fabriziopandini opened this issue Aug 23, 2018 · 4 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@fabriziopandini
Copy link
Member

kubernetes/kubernetes#67786 deprecated feature-gates HighAvailability, SelfHosting, CertsInSecrets in v1.12, so in v1.13 cycle we could cleanup code from HighAvailability, SelfHosting, CertsInSecrets implementation.

As discussed in kubeadm office hours the 22 August 2018, we should consider if to preserve the pivoting logic (currently still accessible as kubeadm alpha phase self hosting) into a separated sub command + eventually implement also un-pivoting

@fabriziopandini fabriziopandini added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 23, 2018
@fabriziopandini fabriziopandini added this to the v1.13 milestone Aug 23, 2018
@fabriziopandini
Copy link
Member Author

/lifecycle active
/assign @Klaven

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to assign the following users: Klaven.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/lifecycle active
/assign @Klaven

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 2, 2018
@fabriziopandini fabriziopandini self-assigned this Oct 2, 2018
@Klaven
Copy link

Klaven commented Oct 3, 2018

Talked about this in the kubeadm office hours on Wed 3 Oct 2018. the high level overview of the work that should be done is as follows:
We will not remove the feature, instead we will move it too it's own command and add a warning about it's limitations and restrictions.

@neolit123
Copy link
Member

closed by:
kubernetes/kubernetes#69878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

4 participants