Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use defer when deleting kubelet-boostrap.conf #1699

Closed
neolit123 opened this issue Jul 31, 2019 · 0 comments · Fixed by kubernetes/kubernetes#80820
Closed

use defer when deleting kubelet-boostrap.conf #1699

neolit123 opened this issue Jul 31, 2019 · 0 comments · Fixed by kubernetes/kubernetes#80820
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.16

Comments

@neolit123
Copy link
Member

neolit123 commented Jul 31, 2019 •
edited
Loading

with this PR merging we are now deleting kubelet-boostrap.conf after boostrap.

however it is better to use defer as outlined in this comment:
kubernetes/kubernetes#80676 (comment)

if you see this ticket please send a PR for kubernetes/kubernetes to use Go's defer for that particular logic, modifying the same file the PR above touches.
@neolit123 neolit123 added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 31, 2019
@mattmelgard mattmelgard mentioned this issue Jul 31, 2019
Merged
@neolit123 neolit123 added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 2, 2019
@neolit123 neolit123 mentioned this issue Aug 3, 2019
Closed
@neolit123 neolit123 added this to the v1.16 milestone Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.16
Development

Successfully merging a pull request may close this issue.

kubeadm: add a defer to kubelet bootstrap token deletion mattmelgard/kubernetes
1 participant
@neolit123