-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overwrite KubeletRunDirectory when init/join #2104
Comments
see here: you can solve this with a symlink. /priority awaiting-more-evidence |
@neolit123 Thanks for reply. Use symlink can solve my problem. But in my case, i use ansible to deploy some clusters, some of them use |
potentially, instead of writing the config always to the default kubelet directory, we can check if the user has passed a KubeletConfiguration and use the value from there. maybe the kubeadm API should support the field (e.g. in NodeRegistrationOptions), instead of making assumption based on KubeletConfiguration. |
/kind design |
I'm +1 to defer this to when the design for node specific settings in component config is complete. |
If the issue #1682 solved, i think this issue also solved. |
related KEP kubernetes/enhancements#1439 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I think we can add KubeletRootDir in v1beta3 like CertificatesDir. I would work on it if there is no objection. |
We have not yet decided how to handle instance specific confinguration in
kubeadm. It is a complicated topic.
|
/unassign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Early investigation for this issue, might not accurate enough, correct me pls.
// KubeletRunDirectory specifies the directory where the kubelet runtime information is stored.
KubeletRunDirectory = "/var/lib/kubelet"
So, this issue still stands, and one tradeoff is making @neolit123 @pacoxu @SataQiu Can we include this in v1beta4? one day the node-specific config is implemented, we can pull this out from clusterConfiguration then, WDYT? |
+1 to remove from cluster scope. it can be a feature in noderegistrationoptions, but i think the demand is relatively low. users can use symlinks too, i think. |
We need to be careful with it. As #2104 (comment) pointed out, kubelet.conf file will place based on the kubelet BTW, kubelet
A question when I implement kubernetes/enhancements#3930: use
|
agreed, i think we should just drop it from the cluster configuration as a start. implementation / piping the option in kubeadm feels google doc proposal worthy. |
the kep in question should be using the kubeletconfiguration to set a local criSocket, maybe by storing a patch file in the kubelet dir, no? i don't think we should use kubelet flags for new features. |
If we support a particular kubelet flag, maybe users want kubeadm to support more, and that would be disastrous.
+1 We should try to avoid to maintain specific flags |
I am trying to understand those statements, for what I can see,
and
And it's config.yaml we should take care of, right? |
what we have from @neolit123 @pacoxu @SataQiu 's comments,
Not sure if anyone would like to take this one. cc @ruquanzhao who might offer some help along the way. |
/assign |
|
In my view, it is not appropriate to touch this file, since it's destributed by package manager, and we have to consider restore it when So, should we keep using paths |
yes, let's close this ticket. EDIT: there is also the --rootfs option. |
Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST
Versions
kubeadm version (use
kubeadm version
): v1.17.2Environment:
kubectl version
): v1.17.2uname -a
):What happened?
I want to change the kubelet run directory when init or join nodes, setting
root-dir
in kubeadm kubeletExtraArgs field of nodeRegistration object. But kubeadm also write the kubelet config.yaml to/var/lib/kubelet
and this behavior make init fail.What you expected to happen?
I hope kubeadm can setting KubeletRunDirectory. I see this variable is constant now.
The code: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go#L244
I want to know my idea wether correct, i see a relate issue: #1478 . If needs, i will try to do it.
How to reproduce it (as minimally and precisely as possible)?
Anything else we need to know?
The text was updated successfully, but these errors were encountered: