Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepull images already in preflight checks #825

Closed
luxas opened this issue May 16, 2018 · 2 comments · Fixed by kubernetes/kubernetes#64105
Closed

Prepull images already in preflight checks #825

luxas opened this issue May 16, 2018 · 2 comments · Fixed by kubernetes/kubernetes#64105
Assignees
@chuckha
Labels
area/UX lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.11

Comments

@luxas
Copy link
Member

luxas commented May 16, 2018

Following up on #812, we should investigate what it takes to try to prepull all required images already in preflight checks, and fail fast if the CRI daemon can't (lets say you're behind some proxy that is misconfigured or similar).

/assign @chuckha
@luxas luxas added kind/enhancement priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/UX lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels May 16, 2018
@luxas luxas added this to the v1.11 milestone May 16, 2018
@detiber detiber mentioned this issue May 21, 2018
Closed
@chuckha
Copy link

chuckha commented May 21, 2018

I started this last week and got pulled off. There's a fun import cycle when implementing this. Util package imports something it shouldn't imo.

@luxas
Copy link
Member Author

luxas commented May 21, 2018

Ok LMK on Slack if you need help resolving that.
What I forgot to mention is that it should check for presence of the image(s) first so it works well in airgapped envs.

@luxas luxas mentioned this issue May 21, 2018
Merged
@chuckha chuckha mentioned this issue May 23, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 29, 2018
Merge pull request #64105 from chuckha/prepull-images
e3a4104 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm: Pull images early in `kubeadm init` by default

kubeadm now pulls container images before the init step.

* This commit also fixes a dependency cycle

**What this PR does / why we need it**:
This PR adds a check to kubeadm preflight checks that pulls images down before kubeadm tries to run them so boot up time of containers does not have to pull.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/kubeadm#825

**Special notes for your reviewer**:
The interface stuff is to remove a dependency cycle where utils pulled in preflight and preflight pulled in utils. I do not think this utils package should be importing preflight.

**Release note**:

```release-note
kubeadm will pull required images during preflight checks if it cannot find them on the system
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
area/UX lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

kubeadm: Pull images early in kubeadm init by default chuckha/kubernetes
2 participants
@chuckha @luxas