-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests for rootless control-plane. #2511
Conversation
Skipping CI for Draft Pull Request. |
this looks fine as a start. as we discussed we can do the following workflow
with the new locally committed "rootless" changes in config.yaml does: |
00069bb
to
f727104
Compare
f727104
to
0712e13
Compare
Done!
Yeah, I think I was missing the template file in testinfra and after adding that it worked. |
0712e13
to
bcc3065
Compare
ok, so my mistake, but we actually do not allow mixing --feature-gates and --config, so the option must be passed via the ClusterConfiguration. it must be done here:
and all the way to here:
then the feature gates can be templated in the v1beta2 and v1beta3 config: kubeadm/kinder/pkg/kubeadm/config.go Lines 38 to 40 in 47c0def
by converting feature gates
under ClusterConfiguration. these calls no longer need the featuregates explicitly: kubeadm/kinder/pkg/cluster/manager/actions/kubeadm-init.go Lines 75 to 77 in bcc3065
because the values would be prepared in config. |
8cc8a01
to
d570be3
Compare
@neolit123 - Thanks! I updated it roughly based on your guidelines, but instead of multiple feature-gates I kept the scope to a single feature-gate for ease of implementation. |
d570be3
to
5fa7ea3
Compare
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Outdated
Show resolved
Hide resolved
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Outdated
Show resolved
Hide resolved
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Outdated
Show resolved
Hide resolved
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Outdated
Show resolved
Hide resolved
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Show resolved
Hide resolved
kinder/cmd/kinder/do/do.go
Outdated
"kubeadm-feature-gate", "", | ||
"the kubeadm feature-gate to be used for init, join and upgrade", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a bit limiting in terms of UX.
that said:
- i don't see having a single test with kinder that tests multiple FGs.
- we don't have that many FGs in kubeadm anyway, currently.
so supporting a single feature gate for the time being seems fine to me.
5fa7ea3
to
fa5720e
Compare
looks unrelated: |
/retest |
the test will not pass until we fix the related issue. |
@@ -0,0 +1,38 @@ | |||
- name: ci-kubernetes-e2e-kubeadm-kinder-rootless-{{ dashVer .KubernetesVersion }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine to me.
could you please send the kubernetes/test-infra PR as well?
running ./hack/update-workflows.sh would write the new file in the test-infra clone that you have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill do that once we merge this to avoid having to keep both in sync.
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Outdated
Show resolved
Hide resolved
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Show resolved
Hide resolved
568fa59
to
51f37f4
Compare
/retest |
1 similar comment
/retest |
kinder/ci/tools/update-workflows/templates/workflows/rootless-tasks.yaml
Show resolved
Hide resolved
51f37f4
to
5b2def0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks, for enduring this review.
now need the test-infra PR and see if it actually works with Prow.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, vinayakankugoyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edit: neolit123
xref #2473
xref kubernetes/enhancements#2568