Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the packages publication verification script #803

Merged
merged 1 commit into from
May 11, 2018
Merged

Update the packages publication verification script #803

merged 1 commit into from
May 11, 2018

Conversation

luxas
Copy link
Member

@luxas luxas commented May 11, 2018 •
edited
Loading

This PR:

  • Adds documentation
  • Doesn't hard-code the supported kubernetes versions so the script actually can work without maintenance (which effectively removes the usefulness of the e2e test)
  • Adds support for rpms in the same script
  • Improves the readability of the output
  • Fixes Make periodic-kubernetes-e2e-debs-pushed green again #799

cc @jamiehannaford @ixdy @timothysc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2018
timothysc
timothysc approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@timothysc timothysc merged commit e18f802 into kubernetes:master May 11, 2018
This was referenced May 11, 2018
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

Assignees

@timothysc timothysc

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luxas @timothysc @k8s-ci-robot