Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the script path and e2e job name for the package publication verification script #8020

Merged
merged 1 commit into from
May 14, 2018

Conversation

luxas
Copy link
Member

@luxas luxas commented May 11, 2018

Incorporates kubernetes/kubeadm#803
Fixes kubernetes/kubeadm#799
Builds upon #5441
This PR:

  • Renames the deb-specific job periodic-kubernetes-e2e-debs-pushed to periodic-kubernetes-e2e-packages-pushed
  • Updates the script path in the kubeadm repo
  • Adds the e2e job to master-blocking, so missing debs/rpms become more visible to the release team.

cc @ixdy @BenTheElder @timothysc @krzyzacy

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2018
@timothysc
Copy link
Member

+1 from me.

- name: periodic-kubernetes-e2e-debs-pushed
test_group_name: periodic-kubernetes-e2e-debs-pushed
- name: periodic-kubernetes-e2e-packages-pushed
test_group_name: periodic-kubernetes-e2e-packages-pushed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question: should this stay in master-blocking dashboard, rather than branch-blocking ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it there for more visibility.
It's good to have it failing more visibly than before so that people actually go triaging it IMO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this job also testing package push for the release branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just pulling and verifying

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, luxas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 666b69a into kubernetes:master May 14, 2018
@k8s-ci-robot
Copy link
Contributor

@luxas: Updated the config configmap from file prow/config.yaml

In response to this:

Incorporates kubernetes/kubeadm#803
Fixes kubernetes/kubeadm#799
Builds upon #5441
This PR:

  • Renames the deb-specific job periodic-kubernetes-e2e-debs-pushed to periodic-kubernetes-e2e-packages-pushed
  • Updates the script path in the kubeadm repo
  • Adds the e2e job to master-blocking, so missing debs/rpms become more visible to the release team.

cc @ixdy @BenTheElder @timothysc @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants