-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the script path and e2e job name for the package publication verification script #8020
Update the script path and e2e job name for the package publication verification script #8020
Conversation
…erification script
+1 from me. |
- name: periodic-kubernetes-e2e-debs-pushed | ||
test_group_name: periodic-kubernetes-e2e-debs-pushed | ||
- name: periodic-kubernetes-e2e-packages-pushed | ||
test_group_name: periodic-kubernetes-e2e-packages-pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question: should this stay in master-blocking dashboard, rather than branch-blocking ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it there for more visibility.
It's good to have it failing more visibly than before so that people actually go triaging it IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this job also testing package push for the release branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just pulling and verifying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see the script covers last three releases, aka https://github.com/kubernetes/kubeadm/blob/master/tests/e2e/verify_packages_published.sh#L30
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, luxas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@luxas: Updated the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Incorporates kubernetes/kubeadm#803
Fixes kubernetes/kubeadm#799
Builds upon #5441
This PR:
periodic-kubernetes-e2e-debs-pushed
toperiodic-kubernetes-e2e-packages-pushed
master-blocking
, so missing debs/rpms become more visible to the release team.cc @ixdy @BenTheElder @timothysc @krzyzacy