kubectl exec: mark -p option as deprecated in the help output

[php-coder]

Is this a request for help?:
No

What keywords did you search in Kubernetes issues before filing this one?:
kubectl deprecate

---

Is this a BUG REPORT or FEATURE REQUEST?:
bug

Kubernetes version (use kubectl version):

$ ./cluster/kubectl.sh version
Client Version: version.Info{Major:"1", Minor:"9+", GitVersion:"v1.9.0-alpha.1.1693+94acd5a076590e-dirty", GitCommit:"94acd5a076590e083df693f08b3b4f17b133165b", GitTreeState:"dirty", BuildDate:"2017-10-25T13:24:02Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9+", GitVersion:"v1.9.0-alpha.1.1693+94acd5a076590e-dirty", GitCommit:"94acd5a076590e083df693f08b3b4f17b133165b", GitTreeState:"dirty", BuildDate:"2017-10-25T13:24:02Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

What happened:
-p option of kubectl exec is deprecated:

./cluster/kubectl.sh exec -p nginx -i -t id
W1025 17:16:42.763587    7619 cmd.go:398] -p POD_NAME is DEPRECATED and will be removed in a future version. Use exec POD_NAME instead.
uid=0(root) gid=0(root) groups=0(root)

But it's not marked as deprecated in the help output:

$ ./cluster/kubectl.sh exec -h | grep -e '-p'
  -p, --pod='': Pod name

What you expected to happen:
Option description should mention deprecation or this option should be absent in the help output.

[yuexiao-wang]

I would like to work on it

[apelisse]

I can't assign it to you, but I greatly appreciate you doing this. I'm looking at your PR right now. Thanks.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[nikhita]

/remove-lifecycle rotten

still relevant

[ksaritek]

I will have a look the issue

[nikhita]

I will have a look the issue

@ksaritek awesome! 🎉

[quasoft]

Update on this issue in kubernetes/kubernetes#54629

[ksaritek]

is that issue relevant to look or is it fixed already?

[apelisse]

Still looks relevant to me:

~> kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.0", GitCommit:"91e7b4fd31fcd3d5f436da26c980becec37ceefe", GitTreeState:"clean", BuildDate:"2018-06-27T20:17:28Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
...
~> kubectl exec -h
Execute a command in a container.

Examples:
  # Get output from running 'date' from pod 123456-7890, using the first
container by default
  kubectl exec 123456-7890 date
  
  # Get output from running 'date' in ruby-container from pod 123456-7890
  kubectl exec 123456-7890 -c ruby-container date
  
  # Switch to raw terminal mode, sends stdin to 'bash' in ruby-container from
pod 123456-7890
  # and sends stdout/stderr from 'bash' back to the client
  kubectl exec 123456-7890 -c ruby-container -i -t -- bash -il
  
  # List contents of /usr from the first container of pod 123456-7890 and sort
by modification time.
  # If the command you want to execute in the pod has any flags in common (e.g.
-i),
  # you must use two dashes (--) to separate your command's flags/arguments.
  # Also note, do not surround your command and its flags/arguments with quotes
  # unless that is how you would execute it normally (i.e., do ls -t /usr, not
"ls -t /usr").
  kubectl exec 123456-7890 -i -t -- ls -t /usr

Options:
  -c, --container='': Container name. If omitted, the first container in the pod
will be chosen
  -p, --pod='': Pod name
  -i, --stdin=false: Pass stdin to the container
  -t, --tty=false: Stdin is a TTY

Usage:
  kubectl exec POD [-c CONTAINER] -- COMMAND [args...] [options]

Use "kubectl options" for a list of global command-line options (applies to all
commands).

[apelisse]

I've just seen the PR from @quasoft so maybe not actually :-/

[apelisse]

Yeah, this is fixed. Github will close it automatically when the PR merges. Thanks everyone.