Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark --pod/-p flag of kubectl exec command as deprecated #66558

Merged
merged 2 commits into from Jul 28, 2018

Conversation

Projects
None yet
6 participants
@quasoft
Copy link
Contributor

quasoft commented Jul 24, 2018

What this PR does / why we need it:
Marks the --pod (-p shorthand) flag of kubectl exec command as deprecated.
Hides the flag from the help menu, but shows a message when command is executed with this flag.

Which issue this PR fixes:
Fixes: kubernetes/kubectl#104

This is a remake of PR #54629.

Release note:

Flag --pod (-p shorthand) of kubectl exec command marked as deprecated
@tanshanshan

This comment has been minimized.

Copy link
Member

tanshanshan commented Jul 24, 2018

/ok-to-test

@quasoft

This comment has been minimized.

Copy link
Contributor Author

quasoft commented Jul 26, 2018

/test pull-kubernetes-e2e-kops-aws

2 similar comments
@quasoft

This comment has been minimized.

Copy link
Contributor Author

quasoft commented Jul 26, 2018

/test pull-kubernetes-e2e-kops-aws

@quasoft

This comment has been minimized.

Copy link
Contributor Author

quasoft commented Jul 27, 2018

/test pull-kubernetes-e2e-kops-aws

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Jul 27, 2018

That's exactly what we need and it works great. Thank you @quasoft
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, quasoft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Jul 27, 2018

@quasoft I was looking at the original PR, and it was also fixing "port-forward". If you want to follow-up by looking-up all the deprecated flags that are not properly deprecated, that'd be awesome.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 28, 2018

Automatic merge from submit-queue (batch tested with PRs 66593, 66727, 66558). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ce227b0 into kubernetes:master Jul 28, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation quasoft authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@quasoft

This comment has been minimized.

Copy link
Contributor Author

quasoft commented Jul 28, 2018

@apelisse It seems the port-forward flag was already removed.

@marpaia

This comment has been minimized.

Copy link
Member

marpaia commented Jul 31, 2018

/sig cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.