-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark --pod/-p flag of kubectl exec command as deprecated #66558
Conversation
/ok-to-test |
/test pull-kubernetes-e2e-kops-aws |
2 similar comments
/test pull-kubernetes-e2e-kops-aws |
/test pull-kubernetes-e2e-kops-aws |
That's exactly what we need and it works great. Thank you @quasoft |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, quasoft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@quasoft I was looking at the original PR, and it was also fixing "port-forward". If you want to follow-up by looking-up all the deprecated flags that are not properly deprecated, that'd be awesome. |
Automatic merge from submit-queue (batch tested with PRs 66593, 66727, 66558). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@apelisse It seems the port-forward flag was already removed. |
/sig cli |
What this PR does / why we need it:
Marks the
--pod
(-p
shorthand) flag of kubectlexec
command as deprecated.Hides the flag from the help menu, but shows a message when command is executed with this flag.
Which issue this PR fixes:
Fixes: kubernetes/kubectl#104
This is a remake of PR #54629.
Release note: