Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark --pod/-p flag of kubectl exec command as deprecated #66558

Merged
merged 2 commits into from
Jul 28, 2018

Conversation

quasoft
Copy link
Contributor

@quasoft quasoft commented Jul 24, 2018

What this PR does / why we need it:
Marks the --pod (-p shorthand) flag of kubectl exec command as deprecated.
Hides the flag from the help menu, but shows a message when command is executed with this flag.

Which issue this PR fixes:
Fixes: kubernetes/kubectl#104

This is a remake of PR #54629.

Release note:

Flag --pod (-p shorthand) of kubectl exec command marked as deprecated

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2018
@tanshanshan
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 24, 2018
@quasoft
Copy link
Contributor Author

quasoft commented Jul 26, 2018

/test pull-kubernetes-e2e-kops-aws

2 similar comments
@quasoft
Copy link
Contributor Author

quasoft commented Jul 26, 2018

/test pull-kubernetes-e2e-kops-aws

@quasoft
Copy link
Contributor Author

quasoft commented Jul 27, 2018

/test pull-kubernetes-e2e-kops-aws

@apelisse
Copy link
Member

That's exactly what we need and it works great. Thank you @quasoft
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, quasoft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2018
@apelisse
Copy link
Member

@quasoft I was looking at the original PR, and it was also fixing "port-forward". If you want to follow-up by looking-up all the deprecated flags that are not properly deprecated, that'd be awesome.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66593, 66727, 66558). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ce227b0 into kubernetes:master Jul 28, 2018
@quasoft
Copy link
Contributor Author

quasoft commented Jul 28, 2018

@apelisse It seems the port-forward flag was already removed.

@marpaia
Copy link
Contributor

marpaia commented Jul 31, 2018

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl exec: mark -p option as deprecated in the help output
6 participants