Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Tutorials: Having .html in URL causes a 404 before redirecting #1380

Merged
merged 2 commits into from
Oct 28, 2016
Merged

Interactive Tutorials: Having .html in URL causes a 404 before redirecting #1380

merged 2 commits into from
Oct 28, 2016

Conversation

BenHall
Copy link
Contributor

@BenHall BenHall commented Oct 5, 2016

I noticed on the Interactive Tutorials that having the .html in the URL was causing a 404 to be displayed before it redirected.

Reproduce:

  1. Visit http://kubernetes.io/docs/tutorials/getting-started/create-cluster/
  2. Scroll to the bottom, click Start Module 1.
  3. 404 page display for a moment, before redirecting.

This change is Reviewable

@devin-donnelly
Copy link
Contributor

This is a known issue with the entire Kubernetes site. However, this PR is about to cause some merge conflicts with a larger fix; let's hang onto it for now.

@devin-donnelly devin-donnelly added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 5, 2016
@devin-donnelly
Copy link
Contributor

@BenHall, as I suspected, there are a bunch of merge conflicts now. We can just close this PR and fix it with a different one, or you could update this one. What do you think?

@BenHall
Copy link
Contributor Author

BenHall commented Oct 11, 2016

@devin-donnelly I've updated my branch with the upstream changes.

@devin-donnelly devin-donnelly added needs-rebase and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 18, 2016
@devin-donnelly
Copy link
Contributor

Still one merge conflict and, unfortunately, there's a new (second) CLA you'll need to sign.

@BenHall
Copy link
Contributor Author

BenHall commented Oct 19, 2016

Updated the merge conflict and signed the CLA

@devin-donnelly devin-donnelly merged commit e5a2f52 into kubernetes:master Oct 28, 2016
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Added Urdu Localization Configurations and content/ur dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants