Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner use of awk #948

Closed
wants to merge 1 commit into from
Closed

Conversation

rbtcollins
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rbtcollins
Copy link
Author

@kelseyhightower here is a new PR.

I've clicked on the cla.developers.google.com link; I then click 'for my company', and then it takes me through to a form to setup a company CLA - which VMWare has already done - and I'm not authorised to sign on behalf of the company :). So - I think perhaps we need to debug this - is there a specific checklist, or a description of the algorithm, so that I can figure out whats going on?

@kelseyhightower
Copy link
Contributor

@rbtcollins How about I make this simple one line change, then maybe we can figure out what's going on with the CLA?

@rbtcollins
Copy link
Author

There's also a change blocked on the same issue on kubernetes itself :/. But sure, I'm fine any which way - this was a drive by fix up after all, a trivial change.

@kelseyhightower
Copy link
Contributor

@rbtcollins Ok, I've fixed this on the master branch. Let's resolve this issue on the main Kubernetes repo. I'm not sure what's going on, but I'm sure we'll get it resolved. Thanks for taking the time to contribute!

mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
* Protocol Detection Blog Post and Images
* Updates from feedback

Signed-off-by: Charles Pretzer <charles@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants