Skip to content

Commit

Permalink
Merge pull request #51141 from ixdy/docker-qemu-register
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 50489, 51070, 51011, 51022, 51141)

Run multiarch/qemu-user-static:register before building cross-arch images

**What this PR does / why we need it**: #48365 inadvertently broke building non-x86 hyperkube images for developers who'd not built non-x86 images before and thus hadn't yet run `multiarch/qemu-user-static:register`. This PR restores that step.

**Release note**:

```release-note
NONE
```

/assign @david-mcmahon @mbohlool @luxas
  • Loading branch information
Kubernetes Submit Queue committed Aug 24, 2017
2 parents c23e5b6 + 6458f34 commit 470eb92
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions build/debian-hyperkube-base/Makefile
Expand Up @@ -51,6 +51,8 @@ endif
mkdir -p ${TEMP_DIR}/cni-bin
tar -xz -C ${TEMP_DIR}/cni-bin -f "cni-tars/${CNI_TARBALL}"

# Register /usr/bin/qemu-ARCH-static as the handler for non-x86 binaries in the kernel
docker run --rm --privileged multiarch/qemu-user-static:register --reset
docker build --pull -t $(REGISTRY)/$(IMAGE)-$(ARCH):$(TAG) $(TEMP_DIR)
rm -rf $(TEMP_DIR)

Expand Down
2 changes: 2 additions & 0 deletions cluster/images/hyperkube/Makefile
Expand Up @@ -38,6 +38,8 @@ endif

cd ${TEMP_DIR} && sed -i.back "s|BASEIMAGE|${BASEIMAGE}|g" Dockerfile

# Register /usr/bin/qemu-ARCH-static as the handler for non-x86 binaries in the kernel
docker run --rm --privileged multiarch/qemu-user-static:register --reset
docker build --pull -t ${REGISTRY}/hyperkube-${ARCH}:${VERSION} ${TEMP_DIR}
rm -rf "${TEMP_DIR}"

Expand Down

0 comments on commit 470eb92

Please sign in to comment.