Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multiarch/qemu-user-static:register before building cross-arch images #51141

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Aug 22, 2017

What this PR does / why we need it: #48365 inadvertently broke building non-x86 hyperkube images for developers who'd not built non-x86 images before and thus hadn't yet run multiarch/qemu-user-static:register. This PR restores that step.

Release note:

NONE

/assign @david-mcmahon @mbohlool @luxas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 22, 2017
@david-mcmahon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2017
@mbohlool
Copy link
Contributor

/lgtm

@ixdy
Copy link
Member Author

ixdy commented Aug 23, 2017

/retest

Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, when/how did this get removed :(?

Anyway, thanks @ixdy for noticing and adding it back.
/lgtm

Feel free to add the approved label someone or do /approve

@ixdy
Copy link
Member Author

ixdy commented Aug 23, 2017

@luxas some clueless person (me) removed it in #48365, unintentionally.

at least I know what it's for, now.

@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-mcmahon, ixdy, luxas, mbohlool, mikedanese

Associated issue: 48365

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50489, 51070, 51011, 51022, 51141)

@k8s-github-robot k8s-github-robot merged commit 470eb92 into kubernetes:master Aug 24, 2017
@ixdy ixdy deleted the docker-qemu-register branch May 15, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants