Skip to content

Commit

Permalink
Merge pull request #69709 from seans3/kubectl-translate-fix
Browse files Browse the repository at this point in the history
kubectl: move translated data into kubectl
  • Loading branch information
k8s-ci-robot committed Oct 18, 2018
2 parents d425258 + b7f8369 commit 4d66eeb
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 4 deletions.
1 change: 1 addition & 0 deletions hack/.spelling_failures
Expand Up @@ -11,6 +11,7 @@ generated.proto
pkg/client/clientset_generated
pkg/client/informers/informers_generated/
pkg/generated
pkg/kubectl/generated
swagger
test/e2e/generated
third_party/
Expand Down
2 changes: 1 addition & 1 deletion hack/boilerplate/boilerplate.py
Expand Up @@ -147,7 +147,7 @@ def file_extension(filename):

skipped_dirs = ['Godeps', 'third_party', '_gopath', '_output', '.git', 'cluster/env.sh',
"vendor", "test/e2e/generated/bindata.go", "hack/boilerplate/test",
"pkg/generated/bindata.go"]
"pkg/kubectl/generated/bindata.go"]

# list all the files contain 'DO NOT EDIT', but are not generated
skipped_ungenerated_files = ['hack/build-ui.sh', 'hack/lib/swagger.sh',
Expand Down
2 changes: 1 addition & 1 deletion hack/generate-bindata.sh
Expand Up @@ -64,7 +64,7 @@ fi
rm -f "${BINDATA_OUTPUT}.tmp"

# These are files for runtime code
BINDATA_OUTPUT="pkg/generated/bindata.go"
BINDATA_OUTPUT="pkg/kubectl/generated/bindata.go"
# IMPORTANT: if you make any changes to these arguments, you must also update
# pkg/generated/BUILD and/or build/bindata.bzl.
go-bindata -nometadata -nocompress -o "${BINDATA_OUTPUT}.tmp" -pkg generated \
Expand Down
1 change: 1 addition & 0 deletions pkg/kubectl/BUILD
Expand Up @@ -118,6 +118,7 @@ filegroup(
"//pkg/kubectl/describe:all-srcs",
"//pkg/kubectl/explain:all-srcs",
"//pkg/kubectl/generate:all-srcs",
"//pkg/kubectl/generated:all-srcs",
"//pkg/kubectl/metricsutil:all-srcs",
"//pkg/kubectl/polymorphichelpers:all-srcs",
"//pkg/kubectl/proxy:all-srcs",
Expand Down
22 changes: 22 additions & 0 deletions pkg/kubectl/generated/BUILD
@@ -0,0 +1,22 @@
load("@io_bazel_rules_go//go:def.bzl", "go_library")

go_library(
name = "go_default_library",
srcs = ["bindata.go"],
importpath = "k8s.io/kubernetes/pkg/kubectl/generated",
visibility = ["//visibility:public"],
)

filegroup(
name = "package-srcs",
srcs = glob(["**"]),
tags = ["automanaged"],
visibility = ["//visibility:private"],
)

filegroup(
name = "all-srcs",
srcs = [":package-srcs"],
tags = ["automanaged"],
visibility = ["//visibility:public"],
)
File renamed without changes.
2 changes: 1 addition & 1 deletion pkg/kubectl/util/i18n/BUILD
Expand Up @@ -11,7 +11,7 @@ go_library(
srcs = ["i18n.go"],
importpath = "k8s.io/kubernetes/pkg/kubectl/util/i18n",
deps = [
"//pkg/generated:go_default_library",
"//pkg/kubectl/generated:go_default_library",
"//vendor/github.com/chai2010/gettext-go/gettext:go_default_library",
"//vendor/github.com/golang/glog:go_default_library",
],
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubectl/util/i18n/i18n.go
Expand Up @@ -24,7 +24,7 @@ import (
"os"
"strings"

"k8s.io/kubernetes/pkg/generated"
"k8s.io/kubernetes/pkg/kubectl/generated"

"github.com/chai2010/gettext-go/gettext"
"github.com/golang/glog"
Expand Down

0 comments on commit 4d66eeb

Please sign in to comment.