Merge pull request #80477 from mborsz/eventssize

Add 'apiserver_watch_events_sizes'
kubernetes · Aug 22, 2019 · ff1e112 · ff1e112
2 parents 1a53325 + 4af189a
commit ff1e112
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/watch.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/watch.go
@@ -238,6 +238,7 @@ func (s *WatchServer) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 			// type
 			unknown.Raw = buf.Bytes()
 			event.Object = &unknown
+			metrics.WatchEventsSizes.WithLabelValues(kind.Group, kind.Version, kind.Kind).Observe(float64(len(unknown.Raw)))
 
 			*outEvent = metav1.WatchEvent{}
 

diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
@@ -148,6 +148,14 @@ var (
 		},
 		[]string{"group", "version", "kind"},
 	)
+	WatchEventsSizes = prometheus.NewHistogramVec(
+		prometheus.HistogramOpts{
+			Name:    "apiserver_watch_events_sizes",
+			Help:    "Watch event size distribution in bytes",
+			Buckets: prometheus.ExponentialBuckets(1024, 2.0, 8), // 1K, 2K, 4K, 8K, ..., 128K.
+		},
+		[]string{"group", "version", "kind"},
+	)
 	// Because of volatality of the base metric this is pre-aggregated one. Instead of reporing current usage all the time
 	// it reports maximal usage during the last second.
 	currentInflightRequests = prometheus.NewGaugeVec(
@@ -171,6 +179,7 @@ var (
 		DeprecatedDroppedRequests,
 		RegisteredWatchers,
 		WatchEvents,
+		WatchEventsSizes,
 		currentInflightRequests,
 	}
 )