Fixes for Deprecation of io/ioutil (in Go 1.16)

[dims]

Please see https://golang.org/doc/go1.16#ioutil

We have a lot of references to ioutil which we need to migrate to newer package(s) mentioned in the url above:
https://cs.k8s.io/?q=io%2Fioutil&i=nope&files=.*%5C.go&excludeFiles=&repos=kubernetes/kubernetes

We also need some verify scripts to ensure we don't add back this package

/area code-organization

[k8s-ci-robot]

@dims: There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

• /sig <group-name>
• /wg <group-name>
• /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

/sig architecture

(seems like this cuts across everything!)

[liggitt]

The package is deprecated but is not planned for removal. Switching is fine, but this is not urgent

[harshanarayana]

@dims mind if I take a look at this ?

/assign @harshanarayana

[dims]

Ack @liggitt !

[harshanarayana]

@dims For the script to verify the and ensure we don't add this back again, can I modify the existing importverifier toolchain to add a new disallowedImports field with similar behavior support as that of allowedImports ?

2021/03/18 19:43:40 Inspecting imports under ./cmd/importverifier...
2021/03/18 19:43:40 - validating imports for 1 packages in the tree
2021/03/18 19:43:40 -- found forbidden imports for k8s.io/kubernetes/cmd/importverifier:
2021/03/18 19:43:40 --- io/ioutil
2021/03/18 19:43:40 - FAIL

- baseImportPath: "./cmd/importverifier"
  disallowedImports:
  - io/ioutil

[liggitt]

ioutil is extremely widely used, and is not actually a problem to continue using... make sure the importverifier doesn't complain if we depend on it transitively via a vendored dependency

[harshanarayana]

@liggitt Sure. I will keep that in mind. I will enable this as a soft warning behavior if that is all right with everyone so that we can warn them but not fail the check right-away. Once we decide to enforce it, we can switch the config to fail the checks.

[liggitt]

@dims, I'm skeptical that this is worth the effort to warn/sweep existing code

[dims]

@liggitt ack on the warn/verify we can deal with that later (i'll check on possibilities). let's focus this issue to just the bulk replace

[harshanarayana]

Ack. Thanks @dims @liggitt

[BenTheElder]

Most of the methods in ioutil have relatively simple implementations that seem stable, doubly so if it's deprecated 🙃
If go isn't planning to remove this package any time soon I'm also not sure it's worth the cost of forcing library consumers to use go1.16+?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale
/priority important-longterm
(based on #100367 (comment). Please feel to correct, if otherwise)

[mythi]

@dims looks like people are still submitting PRs on this topic and they are not getting reviewed. From Go perspective there's no update since the 1.16 announcement (AFAIK). Should we revisit this goal?

[k8s-ci-robot]

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

From Go perspective there's no update since the 1.16 announcement (AFAIK). Should we revisit this goal?

Go compatibility means the deprecated functions will not be removed. I'm not in favor of this goal... I think it's churn with little purpose.

[dims]

/close

[k8s-ci-robot]

@dims: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.