Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate alpha annotation used in CSINode for migration detection #102357

Closed
gnufied opened this issue May 27, 2021 · 13 comments
Closed

deprecate alpha annotation used in CSINode for migration detection #102357

gnufied opened this issue May 27, 2021 · 13 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@gnufied
Copy link
Member

gnufied commented May 27, 2021

I think we should try and replace alpha annotation with a GAed version because I think we will end up having that annotation until k8s makes V2 (which could be forever).

/sig storage

cc @kubernetes/sig-storage-api-reviews

@gnufied gnufied added the kind/bug Categorizes issue or PR as related to a bug. label May 27, 2021
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2021
@msau42
Copy link
Member

msau42 commented May 27, 2021

/triage accepted
/assign @JiaweiWang
@kubernetes/sig-storage-bugs

@k8s-ci-robot
Copy link
Contributor

@msau42: GitHub didn't allow me to assign the following users: jiaweiwang.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/triage accepted
/assign @JiaweiWang
@kubernetes/sig-storage-bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2021
@msau42
Copy link
Member

msau42 commented May 27, 2021

/assign @Jiawei0227

@Jiawei0227
Copy link
Contributor

annotation that is still not in GA:

  1. On CSINode:
  • storage.alpha.kubernetes.io/migrated-plugins: xxx,xxx This is still in alpha
  1. On PVC:
  • volume.beta.kubernetes.io/storage-provisioner: pd.csi.storage.gke.io This is still in Beta

These are the annos that I found need to be upgrade. I am wondering if there is anything else?

@jsafrane
Copy link
Member

jsafrane commented Jul 2, 2021

storage.alpha.kubernetes.io/migrated-plugins: will we need it GA? It marks nodes with list of migrated plugins. CSI migration will GA soon-ish and 2 releases after GA the annotation becomes useless and could be removed. (2 releases because of potentially old kubelets).

volume.beta.kubernetes.io/storage-provisioner: that should probably get GA.

@Jiawei0227
Copy link
Contributor

First PR to update volume.beta.kubernetes.io/storage-provisioner: kubernetes-sigs/sig-storage-lib-external-provisioner#110

But this might not be related to CSI migration lol

@Jiawei0227
Copy link
Contributor

For volume.beta.kubernetes.io/storage-provisioner: pd.csi.storage.gke.io, we better upgrade it in two releases. The first release we update external-provisioner to understand the new annotation and in the next release we update kubernetes to use the new annotation.

@Jiawei0227
Copy link
Contributor

On kubernetes side #104590 is out to prepare updating the storageprovisioner anno.

@jsafrane
Copy link
Member

For volume.beta.kubernetes.io/storage-provisioner: pd.csi.storage.gke.io, we better upgrade it in two releases. The first > release we update external-provisioner to understand the new annotation and in the next release we update kubernetes to use the new annotation.

Kubernetes will need to set both beta and GA annotations for quite some time, beta annotations have the same deprecation policy as regular fields (!).

@Jiawei0227
Copy link
Contributor

Sounds like from the discussion from #104597 is to keep it alpha until all plugins moves to GA and remove it completely. Will close this issue.

@Jiawei0227
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@Jiawei0227: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jiawei0227
Copy link
Contributor

Create #104760 for tracking the beta annotation removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants