Add GA AnnStorageProvisioner annotation to PVC #104590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
sig/apps
|
/retest |
1 similar comment
|
/retest |
jsafrane
reviewed
Aug 26, 2021
Jiawei0227
changed the title
k8s-ci-robot
added
release-note
This PR adds GA AnnStorageProvisioner annotation to a PVC if the PVC requires dynamic provisioning. This also deprecates the beta AnnStorageProvisioner annotation and it will be removed in a later release.
|
/lgtm |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, k8s place a "volume.beta.kubernetes.io/storage-provisioner" annontation on PVC to indicate what should be the right provisoner for this PVC. This anno is consumed by both k8s itself and external-provisioner for CSI support. This anno has been in beta for a while.
In this PR, add the support to also add a GA storage-provisioner annotation. And the beta annotation is deprecated in this release and will be removed in a later release.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig storage
/cc @msau42 @jsafrane @gnufied
/triage accepted