Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2) #104455

Merged
merged 1 commit into from
Aug 30, 2021
Merged

test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2) #104455

merged 1 commit into from
Aug 30, 2021

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Aug 19, 2021 •
edited

What type of PR is this?

/sig windows
/sig testing

/kind feature
/priority important-soon

What this PR does / why we need it:

The Container Images for Windows Server 2022 have been published, and we can start building test images using them, so we can start adding jobs for them.

The image versions for the e2e test images have been bumped in a previous commit [0], but haven't been promoted yet. We don't need to bump them here.

[0] #102599
[1] https://github.com/kubernetes/k8s.io/blob/c8b744d34f4f017ff6989557a2acc37ed2d3f1be/k8s.gcr.io/images/k8s-staging-e2e-test-images/images.yaml#L1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 19, 2021
@claudiubelu claudiubelu changed the title Test images/windows server 2022 (part 2) test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2) Aug 19, 2021
@jsturtevant
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 19, 2021
@jsturtevant
Copy link
Contributor

xref #104451

@jsturtevant jsturtevant mentioned this pull request Aug 19, 2021
Merged
@claudiubelu claudiubelu mentioned this pull request Aug 19, 2021
Merged
@claudiubelu claudiubelu force-pushed the test-images/windows-server-2022-part-2 branch from 87e43b4 to b0807bf Compare August 19, 2021 20:10
@claudiubelu
Copy link
Contributor Author

/assign @mkumatag

mkumatag
mkumatag reviewed Aug 20, 2021
View reviewed changes
test/images/agnhost/README.md
@@ -643,6 +643,7 @@ The Windows `agnhost` image includes a `nc` binary that is 100% compliant with i

## Image

The image can be found at `k8s.gcr.io/e2e-test-images/agnhost:2.32` for both Linux and
The image can be found at `k8s.gcr.io/e2e-test-images/agnhost:2.33` for both Linux and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of this PR but we need to find some other way to avoid mentioning the images with versions here, because this will get outdated anytime or find some way to update this version when a file changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to look into it, but that'll come at a later date.

@claudiubelu
test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2)
2601e23 
The Container Images for Windows Server 2022 have been published, and
we can start building test images using them, so we can start adding
jobs for them.

The image versions for the e2e test images have been bumped in a previous
commit, but haven't been promoted yet. We don't need to bump them here.

httpd-2.4.46-win64-VC15.zip no longer exists, so we have to use
httpd-2.4.48-win64-VC15.zip instead.
@claudiubelu claudiubelu force-pushed the test-images/windows-server-2022-part-2 branch from b0807bf to 2601e23 Compare August 21, 2021 01:02
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@adelina-t adelina-t mentioned this pull request Aug 24, 2021
Closed
3 tasks
@marosset marosset added this to In Review (v1.23) in SIG-Windows Aug 24, 2021
@claudiubelu
Copy link
Contributor Author

@mkumatag can we get these in?

mkumatag
mkumatag approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@mkumatag
Copy link
Member

/hold to get an ack from someone from windows sig

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021
@jsturtevant
Copy link
Contributor

/lgtm
for sig-windows

Thanks @claudiubelu!

@aojea
Copy link
Member

aojea commented Aug 30, 2021

/lgtm
for sig-windows

Thanks @claudiubelu!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-typecheck

@k8s-ci-robot k8s-ci-robot merged commit ff617ed into kubernetes:master Aug 30, 2021
SIG-Windows automation moved this from In Review (v1.23) to Done (v1.23) Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@claudiubelu claudiubelu mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@aojea aojea Awaiting requested review from aojea

Assignees

@jsturtevant jsturtevant

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiubelu @jsturtevant @k8s-ci-robot @mkumatag @aojea