Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: Removes Windows 1903 and 1909 images #102599

Merged
merged 1 commit into from
Aug 12, 2021
Merged

test images: Removes Windows 1903 and 1909 images #102599

merged 1 commit into from
Aug 12, 2021

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jun 4, 2021 •
edited
Loading

What type of PR is this?

/sig windows
/sig testing

/kind cleanup
/priority important-soon

What this PR does / why we need it:

According to the Microsoft documentation, Windows Server 1903 reached its EOL December 8, 2020 [1], and Windows Server 1909 reached its EOL May 11, 2021 [2].

We ne longer need to build images for those OS Versions, since we won't
run tests for them.

[1] https://docs.microsoft.com/en-us/windows-server/get-started-19/whats-new-in-windows-server-1903-1909
[2] https://docs.microsoft.com/en-us/lifecycle/announcements/windows-server-1909-end-of-servicing

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 4, 2021
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 4, 2021
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch 2 times, most recently from 912952e to 26dc3fc Compare June 4, 2021 14:35
@dims
Copy link
Member

dims commented Jun 4, 2021

@claudiubelu let's please get some approvals from @kubernetes/sig-windows-leads folks

@jsturtevant
Copy link
Contributor

/lgtm

Thanks @claudiubelu!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch from 26dc3fc to 6ebfc13 Compare June 25, 2021 12:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch from 6ebfc13 to 288d6d1 Compare July 15, 2021 07:58
@claudiubelu
Copy link
Contributor Author

/assign @mkumatag

marosset
marosset reviewed Jul 28, 2021
View reviewed changes
test/images/README.md Outdated Show resolved Hide resolved
@marosset
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 28, 2021
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch from 288d6d1 to f25eac2 Compare July 29, 2021 08:21
@marosset
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch from f25eac2 to a561e1a Compare August 5, 2021 08:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2021
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-integration

@claudiubelu
test images: Removes Windows 1903 and 1909 images
ea3c7d9 
According to the Microsoft documentation, Windows Server 1903
reached its EOL December 8, 2020 [1], and Windows Server 1909
reached its EOL May 11, 2021 [2].

We ne longer need to build images for those OS Versions, since we won't
run tests for them.

[1]: https://docs.microsoft.com/en-us/windows-server/get-started-19/whats-new-in-windows-server-1903-1909
[2]: https://docs.microsoft.com/en-us/lifecycle/announcements/windows-server-1909-end-of-servicing
@claudiubelu claudiubelu force-pushed the test-images/remove-eol-windows-images branch from a561e1a to ea3c7d9 Compare August 11, 2021 11:50
spiffxp
spiffxp approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4c498db into kubernetes:master Aug 12, 2021
This was referenced Aug 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset left review comments

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@spiffxp spiffxp

@jsturtevant jsturtevant

@mkumatag mkumatag

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@claudiubelu @k8s-ci-robot @dims @jsturtevant @marosset @spiffxp @mkumatag