-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2) #104455
test images: Adds Windows Server 2022 to the BASEIMAGEs (part 2) #104455
Conversation
/triage accepted |
xref #104451 |
87e43b4
to
b0807bf
Compare
/assign @mkumatag |
@@ -643,6 +643,7 @@ The Windows `agnhost` image includes a `nc` binary that is 100% compliant with i | |||
|
|||
## Image | |||
|
|||
The image can be found at `k8s.gcr.io/e2e-test-images/agnhost:2.32` for both Linux and | |||
The image can be found at `k8s.gcr.io/e2e-test-images/agnhost:2.33` for both Linux and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not part of this PR but we need to find some other way to avoid mentioning the images with versions here, because this will get outdated anytime or find some way to update this version when a file changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to look into it, but that'll come at a later date.
The Container Images for Windows Server 2022 have been published, and we can start building test images using them, so we can start adding jobs for them. The image versions for the e2e test images have been bumped in a previous commit, but haven't been promoted yet. We don't need to bump them here. httpd-2.4.46-win64-VC15.zip no longer exists, so we have to use httpd-2.4.48-win64-VC15.zip instead.
b0807bf
to
2601e23
Compare
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
@mkumatag can we get these in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold to get an ack from someone from windows sig |
/lgtm Thanks @claudiubelu! |
/hold cancel |
/test pull-kubernetes-typecheck |
What type of PR is this?
/sig windows
/sig testing
/kind feature
/priority important-soon
What this PR does / why we need it:
The Container Images for Windows Server 2022 have been published, and we can start building test images using them, so we can start adding jobs for them.
The image versions for the e2e test images have been bumped in a previous commit [0], but haven't been promoted yet. We don't need to bump them here.
[0] #102599
[1] https://github.com/kubernetes/k8s.io/blob/c8b744d34f4f017ff6989557a2acc37ed2d3f1be/k8s.gcr.io/images/k8s-staging-e2e-test-images/images.yaml#L1
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: