pass sandbox resource requirements over CRI #104886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
sig/node
egernst
force-pushed
the
cri-pod-overhead
branch
from
db170f7
to
f358f8e
Compare
|
/test pull-kubernetes-verify |
bergwolf
reviewed
Sep 13, 2021
jiangliu
reviewed
Sep 13, 2021
|
We have handled CPU/memory request and limit, how about storage and ephemeral storage? We hope to assigned an ephemeral storage device for confidential containers, so we need to sum containers' request and pod overhead for ephemeral storage too. |
egernst
force-pushed
the
cri-pod-overhead
branch
from
f358f8e
to
bd1e8f0
Compare
k8s-ci-robot
added
size/XL
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
|
@jiangliu -- understand your point re: ephemeral storage. Today this isn't accounted for in terms of resource quota/scheduler, etc, so I'm not sure it'd necessarily make sense to add to this part of the interface. It seems reasonable, but I think it'd make sense as a separate PR. This sound ok? |
egernst
force-pushed
the
cri-pod-overhead
branch
from
cd71c2e
to
fbcb174
Compare
|
/test pull-kubernetes-verify-govet-levee |
egernst
force-pushed
the
cri-pod-overhead
branch
from
fbcb174
to
24a9cdc
Compare
k8s-ci-robot
added
size/XXL
k8s-ci-robot
added
priority/important-soon
egernst
force-pushed
the
cri-pod-overhead
branch
from
c42cb43
to
b6d4c67
Compare
|
Pushed update to:
|
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Currently we only care about the sum of sandbox resources, which includes a pod overhead if defined. We have a need for also calculating *just* the sum of container requests/limits for CPU / Memory, so let's do a refactor and expose this new helper function. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Seperate the CPU/Memory req/limit -> linux resource conversion into its own function for better reuse. Elsewhere in kuberuntime pkg, we will want to leverage this requests/limits to Linux Resource type conversion. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Populate Resources and Overhead fields which, are now part of LinuxPodSandboxConfig. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
egernst
force-pushed
the
cri-pod-overhead
branch
from
b6d4c67
to
2c0fad1
Compare
|
Pushed update to:
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergwolf, egernst, liggitt, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the CRI-api, adding two additional fields to
LinuxPodSandboxConfig: Resources and Overhead. This API change was approved as part of the pod overhead KEP, but was not yet implemented.Kubelet is also updated to populate these fields when generating the sandbox config with the sum of container resources and pod overhead, respectively.
These fields are important to underlying runtimes, like Kata Containers, to facilitate appropriate sandbox sizing. More specifically to Kata, with this a VM can be created with multi-queue for IO sized to match the expected number of vCPUs. Similarly, the sandbox can be created appropriately without requiring CPU/memory hot plug.
Special notes for your reviewer:
Majority of the code changes are:
This change is based on top of #105772 in order to verify that the refactoring doesn't impact existing functionality (which didn't have great unit tests in the first place).
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: