Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated klog flags #105310

Closed
pohly opened this issue Sep 28, 2021 · 13 comments
Closed

remove deprecated klog flags #105310

pohly opened this issue Sep 28, 2021 · 13 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@pohly
Copy link
Contributor

pohly commented Sep 28, 2021

What would you like to be added:

At some point we can remove the legacy klog flags. This change includes:

  • removing the command line check in component-base/logs/validation.go
  • removing the "unsupported flags" warning from the --logging-format help text
  • adding a remark for -vmodule that it only works for text output

Why is this needed:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components

@pohly pohly added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 28, 2021
@shiva1333
Copy link
Contributor

/sig instrumentation
/wg structured-logging

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 28, 2021
@shiva1333
Copy link
Contributor

@pohly please feel free to assign me, I've bandwidth to pick this

@pohly
Copy link
Contributor Author

pohly commented Sep 28, 2021

It's much too early to work on this. 😁

We first must mark the flags as deprecated (#105042) then in Kubernetes 1.26 (?) we can remove them.

@shiva1333
Copy link
Contributor

Okay got it

@logicalhan
Copy link
Member

/triage accepted
/assign @serathius

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 7, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2022
@serathius
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 9, 2022
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 8, 2023
@serathius serathius removed their assignment Feb 8, 2023
@serathius
Copy link
Contributor

Don't have capacity to work on this.

@pohly
Copy link
Contributor Author

pohly commented Feb 8, 2023

/triage accepted
/assign @shivanshu1333

@shivanshu1333: you said that you wanted to work on this - are you still available?

We might be able to do this for 1.27, but I haven't checked.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2023
@shiva1333
Copy link
Contributor

Okay, I'll pick it up...

@pohly
Copy link
Contributor Author

pohly commented Nov 7, 2023

This issue was resolved via #112120 which was already merged for 1.26! I think we forgot about that when re-triaging this issue...

/close

@k8s-ci-robot
Copy link
Contributor

@pohly: Closing this issue.

In response to this:

This issue was resolved via #112120 which was already merged for 1.26! I think we forgot about that when re-triaging this issue...

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WG Structured Logging - Enhancement work automation moved this from Inbox to Done Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Development

No branches or pull requests

6 participants