Code generation outside GOPATH #106964
Merged
Code generation outside GOPATH #106964
+129
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubectl
sig/api-machinery
|
Oof. I have not visited this in a while. Will look. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 1, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor to pull in the fix, update our script to use the `--trim-path-prefix` flag, and check in the resulting incidental deltas to generated files. HIVE-1723
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 2, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 3, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 3, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 3, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 4, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 4, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 4, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 4, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Feb 4, 2022
kubernetes/kubernetes#106964 fixed a bug whereby codegen outside of GOPATH would put generated files under github.com/ relative to the repo root. Revendor k8s.io/code-generator to pull in the fix and update our script to use the --trim-path-prefix flag it introduced. The update resulted in dependency hell, including needing to move to go 1.17. Changes in actual hive code to accommodate updated dependencies include: - Accommodate a new method on workqueue.Interface. - Remove the `--v` flag from the hiveadmission executable -- logging-related CLI options were removed from the underlying command at some point. - Rewrite the logr wrapper we pass to controller-runtime to initialize the managers for the operator and controllers - Repoint where we get our fake clock from for testing expectations. HIVE-1723 HIVE-1753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Add support for the generators in k8s.io/code-generator to output generated files anywhere and not just in GOPATH.
The updated version of k8s.io/gengo now supports a
--trim-path-prefixflag to trim a prefix from a generated file's path before creating it. This can be passed to thegenerate-groups.shscript in k8s.io/code-generator. For example, if you're generating code for github.com/foo/bar, and you have it cloned somewhere not in GOPATH, you can do this:and the generated files will essentially be written relative to the current directory (assuming it's the root of your repo). So github.com/foo/bar/pkg/client will be written to just pkg/client/... and so on.
Which issue(s) this PR fixes:
Fixes kubernetes/code-generator#133
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: