Hack GOPATH for codegen #1676
Hack GOPATH for codegen #1676
Conversation
Copy/adapt [GOPATH ridiculousness](https://github.com/openshift/cloud-credential-operator/blob/aa5510254782d506f59a0578661f22a8d639dc85/hack/update-codegen.sh) from CCO to work around codegen bugs that would generate the code under github.com/ in the repo root. Check in the resulting deepcopy deltas we've apparently been missing for a while. HIVE-1723
|
/assign @akhil-rane |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
=======================================
Coverage 42.36% 42.36%
=======================================
Files 337 337
Lines 31134 31134
=======================================
Hits 13190 13190
Misses 16858 16858
Partials 1086 1086 |
|
from this PR it looks like code generation outside GOPATH should be fixed now. Maybe we should vendor in latest changes and see if that does the trick |
See #1677. The results are quite different:
I don't know if any of that is significant 🤷♂️ |
|
/close in favor of #1679. |
Copy/adapt GOPATH ridiculousness from CCO to work around codegen bugs that would generate the code under github.com/ in the repo root.
Check in the resulting deepcopy deltas we've apparently been missing for a while.
HIVE-1723