Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendor codegen for GOPATH bug #1677

Closed

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Feb 1, 2022

kubernetes/kubernetes#106964 fixed a bug whereby
codegen outside of GOPATH would put generated files under github.com/
relative to the repo root. Revendor to pull in the fix, update our
script to use the --trim-path-prefix flag, and check in the resulting
incidental deltas to generated files.

HIVE-1723

kubernetes/kubernetes#106964 fixed a bug whereby
codegen outside of GOPATH would put generated files under github.com/
relative to the repo root. Revendor to pull in the fix, update our
script to use the `--trim-path-prefix` flag, and check in the resulting
incidental deltas to generated files.

HIVE-1723
@2uasimojo
Copy link
Member Author

/assign @akhil-rane

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member Author

NOTE: This is pulling down an alpha rev of k8s.io/code-generator.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/coverage a12b1f4 link true /test coverage
ci/prow/images a12b1f4 link true /test images
ci/prow/unit a12b1f4 link true /test unit
ci/prow/e2e a12b1f4 link true /test e2e
ci/prow/e2e-pool a12b1f4 link true /test e2e-pool
ci/prow/verify a12b1f4 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member Author

in favor of #1679

@2uasimojo 2uasimojo closed this Feb 2, 2022
@2uasimojo 2uasimojo deleted the HIVE-1723/revendor-codegen branch February 2, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants