Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove runtime in validate #107426

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Remove runtime in validate #107426

merged 2 commits into from
Jan 12, 2022

Conversation

yanghesong
Copy link
Member

Validate is useless as dockershim is removed

Signed-off-by: yanghesong hesong.yang@foxmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Dockershim has been removed, refer to #97252. Change the corresponding error message of dockershim.

Which issue(s) this PR fixes:

Validate is useless as dockershim is removed

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@yanghesong
Remove runtime in validate
6905fef 
Validate is useless as dockershim is removed

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yanghesong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 9, 2022
@yanghesong
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims January 9, 2022 01:17
@yanghesong
Remove runtime in validate
b4f6eb6 
Validate is useless as dockershim is removed

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
@dims
Copy link
Member

dims commented Jan 9, 2022

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2022
@dims
Copy link
Member

dims commented Jan 9, 2022

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 9, 2022
@dims
Copy link
Member

dims commented Jan 9, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2022
wzshiming
wzshiming reviewed Jan 10, 2022
View reviewed changes
pkg/security/apparmor/validate.go
Comment on lines -109 to -113
// Check runtime support. Currently only Docker is supported.
if runtime != kubetypes.DockerContainerRuntime && runtime != kubetypes.RemoteContainerRuntime {
return fmt.Errorf("AppArmor is only enabled for 'docker' and 'remote' runtimes. Found: %q", runtime)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep it, check the case where runtime is not remote

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
refer to #107299

@yanghesong
Copy link
Member Author

/cc @adisky

adisky
adisky reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@adisky adisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adisky adisky added this to Needs Approver in SIG Node PR Triage Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Jan 11, 2022
@yanghesong
Copy link
Member Author

/assign @smarterclayton

@wzshiming
Copy link
Member

/lgtm
/assign @dims

@dims
Copy link
Member

dims commented Jan 12, 2022

@adisky please let me know when this is ready.

@adisky
Copy link
Contributor

adisky commented Jan 12, 2022

this is ready to go @dims

@dims
Copy link
Member

dims commented Jan 12, 2022

/approve

NOTE: cleanup after dockershim

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrunalp, wzshiming, yanghesong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit b5103f6 into kubernetes:master Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 12, 2022
@yanghesong yanghesong mentioned this pull request Nov 8, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky adisky left review comments

@mrunalp mrunalp mrunalp approved these changes

@wzshiming wzshiming wzshiming approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@odinuge odinuge Awaiting requested review from odinuge

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@smarterclayton smarterclayton

@wzshiming wzshiming

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yanghesong @k8s-ci-robot @dims @wzshiming @adisky @mrunalp @smarterclayton