Completely remove in-tree dockershim from kubelet #97252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/dependency
dims
force-pushed
the
drop-dockershim
branch
from
85a5921
to
fd88d78
Compare
|
/test pull-kubernetes-node-e2e-containerd |
|
/uncc |
dims
force-pushed
the
drop-dockershim
branch
2 times, most recently
from
c8dd372
to
2fd754e
Compare
dims
force-pushed
the
drop-dockershim
branch
from
2fd754e
to
468f949
Compare
|
/test pull-kubernetes-node-e2e-containerd |
1 similar comment
|
/test pull-kubernetes-node-e2e-containerd |
|
/lgtm
|
🎉
neolit123
reviewed
Dec 8, 2021
There was a problem hiding this comment.
should these flags be removed?
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/config/flags.go#L92-L112
but note that pod-infra-container-image is definitely not a dockershim only flag.
currently it is used for preventing the kubelet from GC-ing the pause image.
i cannot comment on the other ones, but all must be verified if "dockershim only".
|
@neolit123 Filled an issue for cleanup, we should definitely drop the unused ones (and update the other for now) #106893 |
|
|
ionutbalutoiu
added a commit
to ionutbalutoiu/k8s-e2e-runner
that referenced
this pull request
Dec 13, 2021
In `master` branch, Dockershim was completely removed from the `kubelet`: kubernetes/kubernetes#97252 These jobs will be re-added later using the latest Kubernetes release that supports Docker.
Closed
yanghesong
added a commit
to yanghesong/kubernetes
that referenced
this pull request
Jan 4, 2022
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 5, 2022
remove runDockershim #97252
This was referenced Jan 9, 2022
Closed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://git.k8s.io/enhancements/keps/sig-node/2221-remove-dockershim
This has been pending for a really long time, dockershim has been a drag on sig-node and a huge technical debt. Please see KEP above for relevant details. There are activities in progress to alleviate adoption issues in terms of documentation / surveys / alternate implementations etc. For this PR, we just remove the code that has been deprecated a long time ago in #94624
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: