Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote load balancer class to GA #107979

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Promote load balancer class to GA #107979

merged 1 commit into from
Mar 22, 2022

Conversation

XudongLiuHarold
Copy link
Member

@XudongLiuHarold XudongLiuHarold commented Feb 7, 2022 •
edited

Signed-off-by: Xudong Liu xudongliuharold@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

In #98277 we added a new field in Service that allows users to use a custom load balancer for Service Type=LB. This PR promotes this feature to GA via :

  • update loadBalancerClass feature gate to GA stage
  • add more integration test

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The .spec.loadBalancerClass field for Services is now generally available.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/1959-service-lb-class-field
- [Issue]: https://github.com/kubernetes/enhancements/issues/1959

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2022
@XudongLiuHarold XudongLiuHarold force-pushed the promote-loadbalancerclass-to-ga branch 2 times, most recently from 53c0c54 to 8e81329 Compare February 7, 2022 08:09
aojea
aojea reviewed Feb 7, 2022
View reviewed changes
pkg/features/kube_features.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2022
@XudongLiuHarold XudongLiuHarold force-pushed the promote-loadbalancerclass-to-ga branch 3 times, most recently from 6d350e0 to a71735c Compare February 21, 2022 06:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2022
@XudongLiuHarold XudongLiuHarold mentioned this pull request Feb 21, 2022
Closed
@XudongLiuHarold
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@XudongLiuHarold
Copy link
Member Author

/retest

1 similar comment
@XudongLiuHarold
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 9, 2022
@XudongLiuHarold
Copy link
Member Author

/retest

@XudongLiuHarold
Copy link
Member Author

/retest

@XudongLiuHarold XudongLiuHarold force-pushed the promote-loadbalancerclass-to-ga branch 2 times, most recently from a599a7d to b1b2d2f Compare March 11, 2022 09:33
@XudongLiuHarold
Copy link
Member Author

/retest

@XudongLiuHarold
Copy link
Member Author

Hi @andrewsykim , could you please review this PR again? Thank you!

@andrewsykim andrewsykim mentioned this pull request Mar 15, 2022
Closed
@XudongLiuHarold
Copy link
Member Author

/retest

@XudongLiuHarold
Copy link
Member Author

/test pull-kubernetes-integration

@XudongLiuHarold
Copy link
Member Author

Hi @andrewsykim , could you please review this PR again? I add the waiting time for the integration test cases and test it several times to prove the integration test can pass stably. :) thanks!

/cc @andrewsykim

andrewsykim
andrewsykim reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

/assign @thockin

staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go Outdated Show resolved Hide resolved
@XudongLiuHarold
promote load balancer class to GA
c8a6c7f 
Signed-off-by: Xudong Liu <xudongliuharold@gmail.com>
thockin
thockin reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@XudongLiuHarold
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7cf5c02 into kubernetes:master Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 22, 2022
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Open
@tengqm tengqm mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@thockin thockin

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@XudongLiuHarold @k8s-ci-robot @sftim @thockin @aojea @andrewsykim