-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoadBalancerClass field in service #98277
Add LoadBalancerClass field in service #98277
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @XudongLiuHarold! |
Hi @XudongLiuHarold. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
60184da
to
f052dde
Compare
/assign |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During alpha we need to update Service REST code to drop the field when the feature gate is not enabled. See dropServiceDisabledFields():
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
Outdated
Show resolved
Hide resolved
d4eb02e
to
96f6cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code freeze is coming - ping me when this is ready
@@ -122,6 +122,15 @@ func ValidateDNS1123Label(value string, fldPath *field.Path) field.ErrorList { | |||
return allErrs | |||
} | |||
|
|||
// ValidateQualifiedName validates if name is what Kubernetes calls a "qualified name". | |||
func ValidateQualifiedName(value string, fldPath *field.Path) field.ErrorList { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! We should file a "Good first Issue" issue to change most of the users of IsQualifiedName
to this simpler form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will submit the issue once get this PR merged, thanks @thockin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit issue here: #99828
👋 Hello! I am from the Bug Triage team! As @thockin mentioned, friendly reminder that code freeze is starting March 9th, 2021 (about 1 week from now). We want to ensure that each PR has a chance to be merged before code freeze! |
7733bb4
to
1a8d693
Compare
1a8d693
to
3569cc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 testcase request., Approving and if you get it in good, else followup.
Thanks!
/lgtm
/approve
3569cc0
to
f181ad2
Compare
/lgtm |
f181ad2
to
72da0b1
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
Hi @pohly , according to @nikhita's suggestion here: #98277 (comment), dropped |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements the KEP-1959 Add LoadBalancerClassName field in service.
Which issue(s) this PR fixes:
Fixes #91306
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: