Install-WorkerServices should not set pod-infra-container-image as it is marked for deprecation

[SergeyKanzhelev]

What happened?

This code:

kubernetes/cluster/gce/windows/k8s-node-setup.psm1

Line 1051 in 6644566

"--pod-infra-container-image=${env:INFRA_CONTAINER}",

should not set pod-infra-container-image as it was just marked for deprecation and has to set the sandbox_image instead on Contianerd

What did you expect to happen?

code not setting this flag

How can we reproduce it (as minimally and precisely as possible)?

code issue

Anything else we need to know?

/sig windows
/sig cloud-provider

Kubernetes version

master

Cloud provider

any

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[k8s-ci-robot]

@SergeyKanzhelev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

@SergeyKanzhelev this has one effect currently. preventing the specified image from being garbage collected. (So we tell folks to specify the pause image in the containerd config toml and here - need to do both)

[SergeyKanzhelev]

Rephrased. Thank you!

[NikhilSharmaWe]

/assign

[NikhilSharmaWe]

@dims and @SergeyKanzhelev Could you please inform about where containerd config toml is set in the repo, so that I can set the sandbox_image there instead.

[andrewsykim]

/remove-sig cloud-provider

[SergeyKanzhelev]

@dims and @SergeyKanzhelev Could you please inform about where containerd config toml is set in the repo, so that I can set the sandbox_image there instead.

I'd say function Configure_Containerd in that file. @ibabou can you help identify what test will exercise this code to test it?

[NikhilSharmaWe]

@SergeyKanzhelev Please inform that am I understanding correct -

• We need to remove "--pod-infra-container-image=${env:INFRA_CONTAINER}", from function Start-WorkerServices.
• Add

$default_kubelet_args = @(`
      "--pod-infra-container-image=${env:INFRA_CONTAINER}"
)

to function Configure_Containerd_CniNetworking.

Am I correct, please inform if I am wrong in the comments of the PR.

Also I am not sure about how we will use this change inside the function Configure_Containerd_CniNetworking.

[ibabou]

@dims and @SergeyKanzhelev Could you please inform about where containerd config toml is set in the repo, so that I can set the sandbox_image there instead.

I'd say function Configure_Containerd in that file. @ibabou can you help identify what test will exercise this code to test it?

Yeah, it's here https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/windows/k8s-node-setup.psm1#L1435

Tests covering this are the [sig-windows] suite ones, that creates Windows pools. For example, jobs like this have containerd configured to be used (KUBE_WINDOWS_CONTAINER_RUNTIME=containerd): https://k8s-testgrid.appspot.com/sig-windows-master-release#gce-windows-2019-containerd-master

[NikhilSharmaWe]

@ibabou I am not understanding the conversation about the tests, actually I have not worked much in this domain. Could you please elaborate on what we are trying to achieve now and what steps we should take to achieve that. Please make a comment in the PR made.

Apologies for asking such a vague question.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[NikhilSharmaWe]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[marosset]

--pod-infra-container-image is planned for deprecation in v1.27 because it is used by the garbage collector to know not to clean up this image.
#106893

@SergeyKanzhelev / @ibabou should we close this issue in favor of the one linked above?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[SergeyKanzhelev]

/remove-lifecycle rotten

either one of these two issues should be tracking this.

[SergeyKanzhelev]

@SergeyKanzhelev Please inform that am I understanding correct -

• We need to remove "--pod-infra-container-image=${env:INFRA_CONTAINER}", from function Start-WorkerServices.

Yes

• Add

$default_kubelet_args = @(`
      "--pod-infra-container-image=${env:INFRA_CONTAINER}"
)

to function Configure_Containerd_CniNetworking.

No, in the Configure_Containerd_CniNetworking the setting sandbox_image needs to be specified in containerd config

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.