Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote replaceCoreV1NamespacedPodTemplate test - +1 endpoint coverage #108431

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Promote replaceCoreV1NamespacedPodTemplate test - +1 endpoint coverage #108431

merged 1 commit into from
Mar 14, 2022

Conversation

riaankleinhans
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoint:

  • replaceCoreV1NamespacedPodTemplate

Which issue(s) this PR fixes:
Fixes #108285
Testgrid Link:
Promotion PR should be ready to Merge on 14 March 2022 if there was no faking on the Testgid .

Special notes for your reviewer:
Adds +1 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2022
@riaankleinhans
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 1, 2022
@riaankleinhans riaankleinhans added this to Promotion PRs Needing Two Weeks (flake free) in conformance-definition Mar 1, 2022
@heyste
Copy link
Member

heyste commented Mar 1, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel
multiple unrelated flake

 s: "timed out waiting for the condition",

@heyste
Copy link
Member

heyste commented Mar 2, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel
multiple flakes

s: "timed out waiting for the condition",

/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:633
Mar  1 23:52:10.394: Timed out after 180.001s.

@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6-parallel
multiple unreleated flakes

 s: "timed out waiting for the condition",

@SergeyKanzhelev SergeyKanzhelev removed this from Triage in SIG Node PR Triage Mar 2, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Mar 2, 2022
@riaankleinhans riaankleinhans mentioned this pull request Mar 8, 2022
Closed
6 tasks
@riaankleinhans
Copy link
Contributor Author

The e2e test spent 2 weeks on the testgrid flake free. Unfortunately the test grid history is not showing more than two days at the moment.
This promotion is ready for /LGTM & /Approve

/assign @dims @smarterclayton @johnbelamaric

@dims
Copy link
Member

dims commented Mar 14, 2022

cc @endocrimes @SergeyKanzhelev ( fyi in case you had a concern about moving this to conformance )

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl, SergeyKanzhelev, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit f9be590 into kubernetes:master Mar 14, 2022
conformance-definition automation moved this from Promotion PRs Needing Two Weeks (flake free) to Done Mar 14, 2022
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Mar 14, 2022
SIG Node PR Triage automation moved this from Triage to Done Mar 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@dims dims

@smarterclayton smarterclayton

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
conformance-definition
  
Done
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Write replaceCoreV1NamespacedPodTemplate test - +1 endpoint coverage
8 participants
@riaankleinhans @heyste @dims @smarterclayton @k8s-ci-robot @k8s-triage-robot @SergeyKanzhelev @johnbelamaric