test/integration: improve TestTransform #108495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/test pull-kubernetes-conformance-kind-ga-only-parallel |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
aojea
reviewed
Mar 3, 2022
sttts
reviewed
Mar 8, 2022
sttts
reviewed
Mar 8, 2022
|
@sttts added a GoDoc comment |
stevekuznetsov
force-pushed
the
skuznets/better-rv-math
branch
from
44f0496
to
f4833c9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
stevekuznetsov
force-pushed
the
skuznets/better-rv-math
branch
from
f4833c9
to
33fdbcf
Compare
k8s-ci-robot
removed
the
lgtm
stevekuznetsov
force-pushed
the
skuznets/better-rv-math
branch
from
33fdbcf
to
bdb8de3
Compare
|
Here's an investigation into the implicit logic going on with the parsing ... https://go.dev/play/p/0AEDExX7zwV |
ResourceVersion values are opaque and math should not be done on them. The intent of this test was to watch from a resourceVersion before the moment where the objects were created, and we can find such a version by listing from the API server before the tests begin. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Without such a context, this test would hang without data for 10 minutes, then panic. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/better-rv-math
branch
from
bdb8de3
to
ff8fbc2
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
I mixed my |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/integration: use a known previous resourceVersion
ResourceVersion values are opaque and math should not be done on them.
The intent of this test was to watch from a resourceVersion before the
moment where the objects were created, and we can find such a version by
listing from the API server before the tests begin.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
test/integration: use a context with a deadline for streaming
Without such a context, this test would hang without data for 10
minutes, then panic.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/kind cleanup
/cc @smarterclayton @liggitt @deads2k
/sig api-machinery