RuntimeClass and PodOverhead tests promotion to Conformance #108781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/architecture
ehashman
reviewed
Mar 17, 2022
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
I expected to see a release note - how come I didn't see that? |
|
Ah, maybe the note isn't needing and it's the PR title that's misleading. |
SergeyKanzhelev
changed the title
|
@sftim thank you, fixed the title. |
|
/assign @johnbelamaric @smarterclayton (needs conformance approver) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/sig node
/area test
/area conformance
/sig node
What this PR does / why we need it:
Promoting PodOverhead and RuntimeClass tests to conformance as both features are GA now.
Fixes #96524
KEP: kubernetes/enhancements#688
Tests were green for a long time before #108714 (somehow test grid wouldn't show those tests any longer), after adding PodOverhead test and renaming, they are still green: https://testgrid.k8s.io/sig-node-critical#containerd-NodeConformance&include-filter-by-regex=RuntimeClass I'd think we can waive the 2 weeks green policy.