-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexport mistakenly-exported kube-proxy constants #109845
unexport mistakenly-exported kube-proxy constants #109845
Conversation
@danwinship: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest LGTM but defer to Tim since he has the historical context , as mentioned in the description, this chains were kind of an API between kubelet and kube-proxy |
But at least in the current code, they both define their own constants rather than one of them referencing the chain names from the other. And eventually kubelet won't define any of them. |
e7fc81b
to
b0d9c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
While working on kubernetes/enhancements#3178 I noticed that several of the iptables chain name variables in kube-proxy were exported variables, leading me to worry that they were being referenced from elsewhere and there would be even more places to clean up that referred to kube-proxy's iptables chains.
But in fact, there aren't. Maybe they used to be shared between kube-proxy and kubelet or something, but right now they're just spuriously exported.
Anyway, since we don't want anyone else using these chains without our knowledge, those constants should be package-local.
Which issue(s) this PR fixes:
none
Does this PR introduce a user-facing change?
/sig network
/priority backlog