tls.Dial() validates hostname, no need to do that manually #110029
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/api-machinery
|
/sig api-machinery |
|
/assign @liggitt |
| @@ -101,6 +100,21 @@ func dialURL(ctx context.Context, url *url.URL, transport http.RoundTripper) (ne | |||
| return nil, err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
according to #109750, Handshake validates host... why is this still needed for this path?
There was a problem hiding this comment.
also, should this switch to HandshakeContext (and tls.Dial below switch to tls.Dialer#DialContext?)
There was a problem hiding this comment.
why is this still needed for this path?
It's not, removed. Sorry about that.
also, should this switch to HandshakeContext (and tls.Dial below switch to tls.Dialer#DialContext?)
I wanted to do that in a separate PR in the whole codebase, if you don't mind.
|
would like a second set of eyes on this as well |
Handshake() is still needed for tls.Client() code path. See kubernetes#109750
ash2k
force-pushed
the
ash2k/no-double-tls-validation
branch
from
76bf707
to
29dc50c
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ash2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
+1 |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
tls.Dial()validates hostname, no need to do that manually.VerifyHostname()is still needed for thetls.Client()code path. See #109750.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: