spdyroundtripper: don't need to verify server hostname twice

[aojea]

/kind cleanup

NONE

tls.HandshakeContext() already validates the hostname, no need to do it twice

playground https://gist.github.com/aojea/4e172d7f3835cd3ffc6ea4f83eea6608

xref https://groups.google.com/g/golang-nuts/c/4vnt7NdLvVU/m/b1SJ4u0ikb0J

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

[aojea]

/assign @liggitt

kindly pinging @FiloSottile for confirmation

[FiloSottile]

/assign @liggitt

kindly pinging @FiloSottile for confirmation

Yeah, these look redundant, without InsecureSkipVerify the client will already do a VerifyHostname for the Config.ServerName.

[ash2k]

@aojea I think you are right. I found one more place that does a redundant verify:

kubernetes/staging/src/k8s.io/apimachinery/pkg/util/proxy/dial.go

Line 122 in e7a2ce7

if err := tlsConn.VerifyHostname(host); err != nil {

Here verify needs to only happen in one of the if branches (where tls.Client is used), not always. Perhaps it's worth addressing in this PR too.

[aojea]

/test pull-kubernetes-e2e-kind-ipv6

Kubernetes e2e suite: [sig-api-machinery] ResourceQuota should verify ResourceQuota with cross namespace pod affinity scope using scope-selectors. expand_more

[aojea]

Kubernetes e2e suite: [sig-storage] EmptyDir volumes should support (root,0777,tmpfs) [LinuxOnly] [NodeConformance]
[Conformance] expand_more 10s
Kubernetes e2e suite: [sig-node] Pods should run through the lifecycle of Pods and PodStatus [Conformance] expand_more

/test pull-kubernetes-e2e-kind

[liggitt]

/lgtm
/approve
/milestone v1.25

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apimachinery/pkg/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[fedebongio]

/triage accepted