New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate Failed conditions in job status #110292
Avoid duplicate Failed conditions in job status #110292
Conversation
Welcome @mimowo! |
Hi @mimowo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
in case its status is False or Unknown. In case the status of the pre-existing condition is true we ignore the new condition. If there is no pre-existing failed condition, then append the new failed condition as before. Also, make the condition comparisons less hacky by ignoring timestamp fields in tests.
554331f
to
e298649
Compare
Commits squashed. |
/lgtm |
/assign @smarterclayton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mimowo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest the details of the failure are not loading 🤔 |
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Avoids creation of duplicate failed conditions (multiple conditions with the same type) for a job after a user changes the failed condition status to False. Such duplicate conditions are problematic for other places in the code of job_controller, which assume there is a single condition of a given type and return / process the first only.
Which issue(s) this PR fixes:
Fixes #109904
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
none