New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Remove unused lastContainerStartedTime time.Cache lru #111932
Cleanup: Remove unused lastContainerStartedTime time.Cache lru #111932
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 19 07:42:40 UTC 2022. |
/release-note-none |
/release-note-none |
/lgtm /assign @liggitt @smarterclayton |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azylinski, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
On Jul 21, 2020 @liggitt added "Ensure runtimeCache contains all observed started containers on pod delete": change
On Jul 9, 2021 main part of this functionality was replaced: change , but the lastContainerStartedTime cache left.
The lru cache is being populated and updated, but it's no longer read from.
As a result, since v1.22 onwards, we're building a latest containerStarted events log which is unnecessary.
And, IMHO, it could/should be removed.
Does this PR introduce a user-facing change?
NONE