Some scheduler goroutines are not tracked in the metric

[alculquicondor]

What happened?

The metric scheduler_goroutines is not called in some instances where we initiate routines, like when we call Parallelize

What did you expect to happen?

We increase the counter every time we create a routine.

How can we reproduce it (as minimally and precisely as possible)?

N/A

Anything else we need to know?

The metric is called scheduler_goroutines, but it's already under the scheduler system. So the final metric has the name:

scheduler_scheduler_goroutines. Maybe we should just call it goroutines.

Note that we can't just remove a metric. We need to duplicate and mark the old one as deprecated for a release or two.

Kubernetes version

master

Cloud provider

N/A

OS version

No response

Install tools

No response

Container runtime (CRI) and version (if applicable)

No response

Related plugins (CNI, CSI, ...) and versions (if applicable)

No response

[k8s-ci-robot]

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

@sanposhiho, please assign to yourself if you are already working on this. Otherwise, I think this is a good fit for a new contributor.

[sanposhiho]

@alculquicondor
I've worked on it in #112003 although I didn't create the new metric for renaming.

/sig scheduling
/assign

I'll add the change to create the new metric (+ deprecate the old one) in #112003 as you describe.

[sanposhiho]

/reopen

Let me reopen it so that I don't forget to remove old scheduler_goroutines metric.

@alculquicondor Can we remove scheduler_goroutines metric in the next release? Or should we wait more time?

[k8s-ci-robot]

@sanposhiho: Reopened this issue.

In response to this:

/reopen

Let me reopen it so that I don't forget to remove old scheduler_goroutines metric.

@alculquicondor Can we remove scheduler_goroutines metric in the next release? Or should we wait more time?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

I would wait at least 2 releases, given how old this metric is.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[alculquicondor]

/remove-lifecycle stale

We can remove the old metric in 1.28

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kerthcet]

/remove-lifecycle stale

[alculquicondor]

oh, we can remove the old metric now. Any takers?

[sanposhiho]

thanks @kerthcet !