Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Winkernel Proxier] Implement support for internal traffic policy in windows kube proxy #114419

Closed
princepereira opened this issue Dec 12, 2022 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@princepereira
Copy link
Contributor

princepereira commented Dec 12, 2022

What would you like to be added?

Why is this needed?

  • With these changes, kube proxy will take constant time always for load balancer creation.
  • Implementing InternalTrafficPolicy feature will optimize the load balancer recreation during rolling updates.
  • This will also minimize the leaking of traffic through stale deleting endpoints during rolling update.
@princepereira princepereira added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

@princepereira: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@princepereira
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2022
@princepereira
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Dec 17, 2022
@thockin
Copy link
Member

thockin commented Dec 21, 2022

Who gets assigned windows kube-proxy issues now? @danwinship

@thockin
Copy link
Member

thockin commented Jan 5, 2023

@MikeZ87

@thockin
Copy link
Member

thockin commented Jan 5, 2023

/assign @bridgetkromhout

@bridgetkromhout
Copy link
Member

/assign @MikeZappa87

@MikeZappa87
Copy link

This can be closed as the referenced PR has been merged.

/close

@k8s-ci-robot
Copy link
Contributor

@MikeZappa87: Closing this issue.

In response to this:

This can be closed as the referenced PR has been merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
Status: Done
Development

No branches or pull requests

5 participants