Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] add test for pkg/probe/http/request.go #114426

Merged
merged 1 commit into from Mar 10, 2023
Merged

[UT] add test for pkg/probe/http/request.go #114426

merged 1 commit into from Mar 10, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Dec 12, 2022

What type of PR is this?

add test for pkg/probe/http/request.go

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 12, 2022
@my-git9
Copy link
Member Author

my-git9 commented Dec 12, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Dec 15, 2022

/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2022
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Dec 15, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Dec 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7435028565d4219ed731c7729eadac02957f32dd

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Dec 28, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2022
@my-git9 my-git9 requested review from aojea and removed request for Random-Liu, bart0sh and krmayankk December 29, 2022 09:44
@my-git9
[ut] add test for pkg/probe/http/request.go
8848f84 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 requested a review from aojea December 30, 2022 02:15
@bart0sh
Copy link
Contributor

bart0sh commented Dec 30, 2022

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Dec 30, 2022

@my-git9 It doesn't have to be in this PR, but it would be nice to test other functions and uncovered code in the same file.

SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0368ee76c9bfc2d55c97314c26649d383b59552

@derekwaynecarr
Copy link
Member

Thank you for the test.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, my-git9, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@my-git9
Copy link
Member Author

my-git9 commented Mar 10, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 78fe7c0 into kubernetes:master Mar 10, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@aojea aojea Awaiting requested review from aojea

Assignees

@derekwaynecarr derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@my-git9 @k8s-triage-robot @bart0sh @k8s-ci-robot @derekwaynecarr @aojea @SergeyKanzhelev