Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KMSv2] log request metadata as part of read/write #116055

Merged
merged 1 commit into from Feb 27, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Logs additional metadata as part of transform to_storage and from_storage.

Which issue(s) this PR fixes:

Fixes #111923

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP] https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2023
@aramase
Copy link
Member Author

aramase commented Feb 25, 2023

/sig auth
/triage accepted
/priority important-soon

/assign @enj

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2023
@enj
Copy link
Member

enj commented Feb 25, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2023
@enj
Copy link
Member

enj commented Feb 25, 2023

/lgtm cancel

Looks like CI linting doesn't like building arguments. Maybe create a separate function that returns a default request info if it's not present? So the actual log statement would be able to use it unconditionally?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2023
@aramase
Copy link
Member Author

aramase commented Feb 26, 2023

/lgtm cancel

Looks like CI linting doesn't like building arguments. Maybe create a separate function that returns a default request info if it's not present? So the actual log statement would be able to use it unconditionally?

done!

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@enj
Copy link
Member

enj commented Feb 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d353a3ac0e526e4a148483c0fb03ddb78bc0b2e8

@k8s-ci-robot k8s-ci-robot merged commit 53b8170 into kubernetes:master Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 27, 2023
@aramase aramase deleted the aramase/f/kubernetes#111923 branch February 27, 2023 01:02
@sftim
Copy link
Contributor

sftim commented Feb 28, 2023

I think users could observe the outcome of this merge. Where'll we changelog it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

[KMSv2] Add additional logging with UID and metadata
4 participants