-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KMSv2] log request metadata as part of read/write #116055
[KMSv2] log request metadata as part of read/write #116055
Conversation
/sig auth /assign @enj |
db2ab81
to
00b6b50
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel Looks like CI linting doesn't like building arguments. Maybe create a separate function that returns a default request info if it's not present? So the actual log statement would be able to use it unconditionally? |
00b6b50
to
016de4d
Compare
done! |
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
016de4d
to
e40b3cf
Compare
/lgtm |
LGTM label has been added. Git tree hash: d353a3ac0e526e4a148483c0fb03ddb78bc0b2e8
|
I think users could observe the outcome of this merge. Where'll we changelog it? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
to_storage
andfrom_storage
.Which issue(s) this PR fixes:
Fixes #111923
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: