-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API approvers #116918
Add API approvers #116918
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Mar 24 16:22:46 UTC 2023. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
+1 |
This PR was too awesome for github 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!!
/lgtm
/approve
LGTM label has been added. Git tree hash: efa69e0d699a21d9255a22b5bb55c973787197f6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Add @deads2k and @msau42 as API approvers.
/kind feature
/sig architecture
I also took a first pass at adding them to sig-focused approver lists where I know they have specific domain knowledge. Those aliases are mostly informational / for steering bot approval suggestions.
Special notes for your reviewer:
Context:
Does this PR introduce a user-facing change?
/cc @deads2k @msau42
/assign @dims @johnbelamaric @derekwaynecarr
for approval per
kubernetes/OWNERS
Line 10 in 0c62b12