Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API approvers #116918

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add API approvers #116918

merged 1 commit into from
Apr 12, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 24, 2023

What type of PR is this?

Add @deads2k and @msau42 as API approvers.

/kind feature
/sig architecture

I also took a first pass at adding them to sig-focused approver lists where I know they have specific domain knowledge. Those aliases are mostly informational / for steering bot approval suggestions.

Special notes for your reviewer:

Context:

Does this PR introduce a user-facing change?

NONE

/cc @deads2k @msau42

/assign @dims @johnbelamaric @derekwaynecarr
for approval per

- sig-architecture-approvers # for OWNERS_ALIASES and other root files

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Mar 24 16:22:46 UTC 2023.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2023
@aojea
Copy link
Member

aojea commented Mar 24, 2023

+1

@liggitt
Copy link
Member Author

liggitt commented Mar 24, 2023

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/116918/pull-kubernetes-integration/1639367415596847104

Downloading https://github.com/coreos/etcd/releases/download/v3.5.7/etcd-v3.5.7-linux-amd64.tar.gz failed. 1 retries left.
curl: (60) SSL certificate problem: certificate has expired

This PR was too awesome for github 😬

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efa69e0d699a21d9255a22b5bb55c973787197f6

@liggitt
Copy link
Member Author

liggitt commented Mar 24, 2023

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.28 milestone Mar 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d5c092 into kubernetes:master Apr 12, 2023
@liggitt liggitt deleted the api-approvers branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants