Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SeccompProfilePath #117045

Closed
SergeyKanzhelev opened this issue Mar 31, 2023 · 16 comments · Fixed by #117050
Closed

Remove SeccompProfilePath #117045

SergeyKanzhelev opened this issue Mar 31, 2023 · 16 comments · Fixed by #117050
Assignees
@pgaijin66 @kaminn @Aakash-chouksey @ashutosh887 @charles-chenzz @vibovenkat123 @shivam-m-7
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@SergeyKanzhelev
Copy link
Member

Look for "// TODO: Deprecated, remove after we switch to Seccomp field". Fix it. See #115898 as example.

/cc @saschagrunert

/help
/good-first-issue
/sig node

add @saschagrunert as a reviewer when sending a PR.

(issue is a follow up from https://github.com/kubernetes/kubernetes/pull/117020/files#r1154025906)
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Look for "// TODO: Deprecated, remove after we switch to Seccomp field". Fix it. See #115898 as example.

/cc @saschagrunert

/help
/good-first-issue
/sig node

add @saschagrunert as a reviewer when sending a PR.

(issue is a follow up from https://github.com/kubernetes/kubernetes/pull/117020/files#r1154025906)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev mentioned this issue Mar 31, 2023
Merged
@charles-chenzz
Copy link
Member

I will start to look at it and fix part of them

/assign

@chetanguptaa chetanguptaa mentioned this issue Apr 1, 2023
Closed
@charles-chenzz charles-chenzz mentioned this issue Apr 1, 2023
Merged
@vamshi1188
Copy link

/assign

@AmeyDagaria007
Copy link

/assign

@AmeyDagaria007 AmeyDagaria007 removed their assignment Apr 2, 2023
@pgaijin66
Copy link

/assign

@kaminn
Copy link

kaminn commented Apr 3, 2023

/assign

@kaminn kaminn mentioned this issue Apr 4, 2023
Closed
@vamshi1188 vamshi1188 removed their assignment Apr 4, 2023
@tmrpavan
Copy link

tmrpavan commented Apr 9, 2023

I would like to work on this issue. Can you assign this to me?

/assign

tmrpavan added a commit to tmrpavan/kubernetes that referenced this issue Apr 9, 2023
@tmrpavan
kubernetes#117045 Remove SeccompProfilePath
e6c643e 
Why are we solving this issue?
Look for "// TODO: Deprecated, remove after we switch to Seccomp field"

To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Look for "// TODO: Deprecated, remove after we switch to Seccomp field"

Does this issue have zero to low barrier of entry?
Yes
@vibovenkat123
Copy link

/assign

@ashutosh887
Copy link

Should I work on this Issue?
/assign

This was referenced Apr 13, 2023
Closed
Closed
@sherifhmdy sherifhmdy removed their assignment Apr 13, 2023
This was referenced Apr 13, 2023
Closed
Closed
@sherifhmdy sherifhmdy removed their assignment Apr 14, 2023
@sherifhmdy
Copy link

/assign

@sherifhmdy sherifhmdy mentioned this issue Apr 15, 2023
Closed
@shivam-m-7
Copy link

Should I work on this Issue?
/assign

@sherifhmdy sherifhmdy removed their assignment Apr 17, 2023
@sherifhmdy
Copy link

@shivam-m-7 I believe there is someone working on this now, and in approving phase, so it's kinda done.

@tmrpavan tmrpavan removed their assignment Apr 17, 2023
@Abhi-y2003
Copy link

Abhi-y2003 commented Apr 19, 2023 •
edited
Loading

Hey, I would like to work on this.
/assign

@Aakash-chouksey
Copy link

i got it!!
/assign

@Swapnil-2502 Swapnil-2502 removed their assignment Apr 23, 2023
@Amshu-k
Copy link

Amshu-k commented Apr 24, 2023

/assign

@Amshu-k Amshu-k removed their assignment Apr 24, 2023
@chengjoey chengjoey mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgaijin66 pgaijin66

@kaminn kaminn

@Aakash-chouksey Aakash-chouksey

@ashutosh887 ashutosh887

@charles-chenzz charles-chenzz

@vibovenkat123 vibovenkat123

@shivam-m-7 shivam-m-7

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone