Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic resource allocation: refactoring overall flow of prepare/unprepare resources #119469

Closed
4 tasks
TommyStarK opened this issue Jul 20, 2023 · 10 comments
Closed
4 tasks
Assignees
Labels
area/kubelet lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@TommyStarK
Copy link
Contributor

TommyStarK commented Jul 20, 2023

  • Implement a clean way to determine which API the gRPC server supports
    Proposal:
    - detect version in a lazy way, i.e. on the first real call and only set the version if the call succeeds
    - better approach could be to specify supported API version at the plugin registration time but it implies deeper changes as it affects devices plugins and csi plugins
  • Avoid falling back to v1alpha2 API on every call
  • Update end-to-end tests using KIND
  • Update dra e2e node tests

Tasks

No tasks being tracked yet.
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TommyStarK
Copy link
Contributor Author

/sig node
/area kubelet
/assign
/cc @bart0sh @klueska

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 20, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jul 20, 2023

Update end-to-end tests using KIND

Do you mean fix failing tests or add new ones?

@TommyStarK
Copy link
Contributor Author

TommyStarK commented Jul 20, 2023

I mean both, imo we will need to update the current tests but also add new ones to test our changes are working as expected

@bart0sh
Copy link
Contributor

bart0sh commented Jul 20, 2023

Thanks for the explanations. btw, dra e2e node tests doesn't use kind. are you planning to update them?

@TommyStarK
Copy link
Contributor Author

I forgot about the dra e2e node tests. IMHO we should also look at them. I've updated the issue accordingly. I know this is going to be a big amount of work but I do think it's necessary.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Feb 24, 2024

/close
The issue is fixed by #120099

@k8s-ci-robot
Copy link
Contributor

@bart0sh: Closing this issue.

In response to this:

/close
The issue is fixed by #120099

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubelet lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

4 participants