Use environment variables for parameters in Powershell #120128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a defense in depth, pass parameters to powershell via environment variables. Signed-off-by: James Sturtevant <jstur@microsoft.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
ritazh
changed the title
This was referenced Aug 23, 2023
|
/retest |
2 similar comments
|
/retest |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 702284e2b5e1975dbd9278b61f048f5e80a53310
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, marosset, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ritazh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 23, 2023
Cherry pick of #120128 Use environment variables for parameters in Powershell
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 23, 2023
Cherry pick of #120128 Use environment variables for parameters in Powershell
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 23, 2023
Cherry pick of #120128 Use environment variables for parameters in Powershell
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 23, 2023
Cherry pick of #120128 Use environment variables for parameters in Powershell
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 23, 2023
Cherry pick of #120128 Use environment variables for parameters in Powershell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
As a defense in depth, pass parameters to powershell via environment variables.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig storage
/sig windows