New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use environment variables for parameters in Powershell #120128
Conversation
As a defense in depth, pass parameters to powershell via environment variables. Signed-off-by: James Sturtevant <jstur@microsoft.com>
/triage accepted |
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 702284e2b5e1975dbd9278b61f048f5e80a53310
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, marosset, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ritazh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherry pick of #120128 Use environment variables for parameters in Powershell
Cherry pick of #120128 Use environment variables for parameters in Powershell
Cherry pick of #120128 Use environment variables for parameters in Powershell
Cherry pick of #120128 Use environment variables for parameters in Powershell
Cherry pick of #120128 Use environment variables for parameters in Powershell
What type of PR is this?
/kind bug
What this PR does / why we need it:
As a defense in depth, pass parameters to powershell via environment variables.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig storage
/sig windows