-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go1.22: update golang.org/x/tools to fix typecheck/TestVerify #120142
Comments
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind failing-test |
/remove-kind bug |
/sig testing |
Tried updating Looks like only after the new release of |
hmmm, SIG Testing isn't testing with golang @ tip, I'm not sure that's something we're aiming for. For a while sig scalability had something, i'm not sure what the status on that is. |
officially, kubernetes is built with a particular version, and that's what we run tests with. (.go-version) |
We have an internal CI job that tests k8s with master golang on ppc64le. We do this to foresee any bugs and compatibility issues between k8s and golang. Can we keep this issue open till we get the next release of |
@Rajalakshmi-Girish if we are not fixing anything in k8s then lets close this issue. |
Updating the version of This test PASSES with master go when |
|
I think we have a vested interest in future go releases working, but I don't know if that includes tracking go @ tip continuously and I'm not sure SIG Testing should have a bug assigned, unless we plan to operate CI for this upstream. This looks like "when we adopt go 1.22 we'll need to update a library". cc @liggitt |
yeah... I don't think this is a bug for us yet. It's helpful to know so we can update the tools library once it tags a release that includes this, but we wouldn't pick up a prerelease of a library to fix a test failure against a pre-release stdlib :) |
/area code-organization |
assigned to v1.30, will track as part of adopting go1.22, since Kubernetes 1.29 will release on go1.21 |
/sig architecture testing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Hello! As this issue is tagged for 1.30, is it still planned for this release? |
yes, this already happened in #122412 /close |
@liggitt: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the update @liggitt |
What happened?
UT typecheck/TestVerify crashing when run with golang tip version.
This is happening after golang/go@5fa4aac
What did you expect to happen?
Test must PASS when run with master golang version
How can we reproduce it (as minimally and precisely as possible)?
Anything else we need to know?
golang/go#62247
OS version
The text was updated successfully, but these errors were encountered: